Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Rust to version 1.77 #557

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Bump Rust to version 1.77 #557

merged 1 commit into from
Aug 28, 2024

Conversation

wprzytula
Copy link
Collaborator

When trying to build rowan we get this error

error: package `rowan v0.15.16` cannot be built because
it requires rustc 1.77.0 or newer, while the currently active rustc
version is 1.75.0

So let's upgrade to 1.77 to allow us to build rowan.

@wprzytula
Copy link
Collaborator Author

@jrvanwhy

@jrvanwhy jrvanwhy added the upkeep Indicates a PR is upkeep as defined by the code review policy. label Aug 28, 2024
lschuermann
lschuermann previously approved these changes Aug 28, 2024
@lschuermann
Copy link
Member

LGTM, but seems like some syntax changed around thread_local!:

 error: initializer for `thread_local` value can be made `const`
  --> unittest/src/kernel_data.rs:31:76
   |
31 | thread_local!(pub(crate) static KERNEL_DATA: RefCell<Option<KernelData>> = RefCell::new(None));
   |                                                                            ^^^^^^^^^^^^^^^^^^ help: replace with: `const { RefCell::new(None) }`

@wprzytula
Copy link
Collaborator Author

wprzytula commented Aug 28, 2024

Now CI (clippy) complains about optimisations possible with the new toolchain. Nothing to be done with this PR.

@lschuermann
Copy link
Member

Now CI (clippy) complains about optimisations possible with the new toolchain. Nothing to be done with this PR.

Typically we do address those in tandem with version updates. This PR should pass CI on its own.

When trying to build rowan we get this error

    error: package `rowan v0.15.16` cannot be built because
    it requires rustc 1.77.0 or newer, while the currently active rustc
    version is 1.75.0

So let's upgrade to 1.77 to allow us to build rowan.
@jrvanwhy jrvanwhy added this pull request to the merge queue Aug 28, 2024
Merged via the queue into tock:master with commit e35d696 Aug 28, 2024
3 checks passed
@wprzytula wprzytula deleted the rust-bump branch August 29, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upkeep Indicates a PR is upkeep as defined by the code review policy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants