Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

property attribute #11

Closed
bhartzler opened this issue Dec 5, 2014 · 2 comments
Closed

property attribute #11

bhartzler opened this issue Dec 5, 2014 · 2 comments
Assignees
@toddreed
Milestone
2.0

Comments

@bhartzler
Copy link

I think you want "strong" on this property attribute, no? I'm getting a warning in xcode 5.1 with mixed arc/non-arc code.

@Property (nonatomic, strong) UIImage *customTouchImage;
@jjxtra
Copy link

jjxtra commented Feb 9, 2015

Yes, I agree. This needs a strong property.

@toddreed toddreed added this to the 2.0 milestone Sep 25, 2016
@toddreed toddreed self-assigned this Sep 25, 2016
toddreed added a commit that referenced this issue Sep 26, 2016
@toddreed
Refactoring to address crash
e13699e 
This refactoring introduces a backwards incompatible API change: the `alwaysShowTouches` and `showTouchesWhenKeyboardShown` properties are now gone, and the semantics of `showTouches` has changed.

`showTouches` is now more predictable and reflects whether touches are being rendered or not. `alwaysShowTouches` is sort of replaced by `automaticallyManageTouchesWhenScreenMirrored`, which, if YES, will automatically set `showTouches`.

Added a notification (QTouchposeTouchesVisibleDidChange) for monitoring changes to `showTouches`.

This resolves #16 and resolves #11.
@toddreed
Copy link
Owner

All properties of retainable object type now explicitly specify their ownership (strong, weak, ...), but no guarantee that this mixed ARC/non-ARC code will work. At this stage, hopefully everybody is 100% ARC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@toddreed toddreed

Labels
None yet
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
3 participants
@toddreed @jjxtra @bhartzler