Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"There are new posts" indicator should maybe ignore pagination #118

Open
winks opened this issue Nov 22, 2024 · 1 comment
Open

"There are new posts" indicator should maybe ignore pagination #118

winks opened this issue Nov 22, 2024 · 1 comment

Comments

@winks
Copy link
Contributor

winks commented Nov 22, 2024

If you're on the starting page (page=1) then clicking Refresh on the "There are new posts!" toast displays the new posts.

But if you are on a page N (N>1) when a new post comes in then it will display the last post of page N-1, which of course makes sense in the ordering of the posts, but I would not expect it to refresh the not-so-new post onto page N.

Solution: No idea, I'm just wondering if a "Refresh and go to page 1" link would make sense, or not display the toast when you are on page 2...

But like this feels a little odd. (Great feature overall though)

@toddsundsted
Copy link
Owner

toddsundsted commented Nov 22, 2024

yes, i don't love the current implementation.

both 1) turning it off on pages other than the first page, or 2) having it refresh and go to the first page are equally easy to do. maybe another option is 3) include a "dismiss" button to just close it and make it go away

i probably lean toward 1) because i don't generally go paging back through history, but when i do i probably don't want to be bothered with a notification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants