-
-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate the React Next example into to the playground Vite environment #818
Comments
if we use vite to build react. There will have no SSR |
IMO for the |
Building the next project for each PR is necessary. In case of people import some side effect code in SSR mode. We could remove it from vercel build it at least need a build test |
This makes sense, so how about having an In this case, we can just keep the Vercel integration, and adding the build test of this |
discussion #844 |
Closing in favor of #838 |
We have a React hook binding with Next.js example at packages/react/examples/next. However since #815, this kind of example can be built using the default Vite playground. Also:
pnpm
monorepo, so it has to be installed manually.kebab-case.ts
).So it will be good to migrate this example to
playground/examples/react
, this can also remove theblocksuite-react
integration in Vercel./cc @himself65
The text was updated successfully, but these errors were encountered: