Allow duplicate group names while validating no duplicate tokens #2827
Conversation
|
|
Tests failing here (I'm not able to copy paste that JSON in, leads to errors) Slight UX feedback on a different set of JSON that i used: Try to rename the |
…tests and util function
| @@ -95,7 +95,24 @@ | |||
| }, | |||
| "duplicate": "Duplicate", | |||
| "rename": "Rename", | |||
| "renameGroupError": "There's an existing token or group with that name", | |||
| "renameGroupModal": { | |||
There was a problem hiding this comment.
can you add the translations to these for all the other languages?
| const newName = 'buttons3'; | ||
| expect(validateRenameGroupName(tokens2[activeTokenSet], type, oldName, newName)).toEqual(null); | ||
| }); | ||
| // FIXME: Test is disabled, as this should not be a blocking issue. If there is just one of each incorrect values, it is still giving the correct error/overlapping token |
| const newName = 'buttons.foo'; | ||
| expect(validateDuplicateGroupName(tokens, selectedTokenSets, activeTokenSet, type, oldName, newName)).toEqual(null); | ||
| }); | ||
| it('prevent overlapping token name with group name', () => { |
There was a problem hiding this comment.
can you start all with should... ? that feels easier to read (it should prevent overlapping..)
|
I'll merge this in - can you add the comments of mine in a follow-up PR? |
Why does this PR exist?
Fixes #2778
What does this pull request do?
Testing this change
Import this JSON
{ "buttons123": { "default": { "value": "#0fa", "type": "color" }, "primary": { "value": "#0af", "type": "color" }, "secondary": { "value": "#a0f", "type": "color" }, "superlongtokenname": { "value": "#0af", "type": "color" } }, "buttons": { "default": { "value": "16", "type": "sizing" }, "primary": { "value": "12", "type": "sizing" }, "superlongtokenname": { "value": "16", "type": "sizing" } }, "buttons2": { "value": "12", "type": "sizing" }, "buttons3": { "test": { "value": "16", "type": "spacing" } } }Try to rename and duplicate the
buttons123group tobuttonsandbuttons2. These should show error messages with the conflicting token(s).Renaming/duplicating
buttons123tobuttons3should be allowed.Additional Notes (if any)
Before
After