Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2623 20 add new sync provider change to modal #2833

Merged
merged 7 commits into from
Jun 15, 2024

Conversation

LukeFinch
Copy link
Contributor

Why does this PR exist?

Closes #2623

Sync providers list was getting too long in a dropdown menu, time to move it into a modal.

What does this pull request do?

  • Moved 'add new sync provider' next to the heading – (Happy to move this back, but it feels better there for me with a long list of sync providers)
  • Moved options into a modal
  • Providers can have a description
  • Added a 'Beta' value - shows a beta badge (reused from SecondScreen) - for some visual consistency

image

Testing this change

Additional Notes (if any)

Copy link

changeset-bot bot commented Jun 10, 2024

⚠️ No Changeset found

Latest commit: ffe9b1a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@robinhoodie0823 robinhoodie0823 requested a review from six7 June 14, 2024 11:08
@six7 six7 merged commit 56f6225 into release-139 Jun 15, 2024
7 of 8 checks passed
@six7 six7 deleted the 2623-20-add-new-sync-provider-change-to-modal branch June 15, 2024 09:31
@six7 six7 linked an issue Jun 15, 2024 that may be closed by this pull request
@six7 six7 added the 2.0-rc8 label Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.0]: Add new sync provider / change to modal
4 participants