Fix/ when switching to input mode from a referenced Border token, all… #2850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fields are now editable
🦋 Changeset detectedLatest commit: bcc2a28 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
akshay-gupta7
commented
Jun 12, 2024
Comment on lines
+292
to
+302
| const setBorderValue = React.useCallback( | ||
| (newBorderValue: SingleBorderToken['value']) => { | ||
| if (internalEditToken?.type === TokenTypes.BORDER && typeof newBorderValue === 'object') { | ||
| setInternalEditToken({ | ||
| ...internalEditToken, | ||
| value: { ...newBorderValue }, | ||
| }); | ||
| } | ||
| }, | ||
| [internalEditToken], | ||
| ); |
There was a problem hiding this comment.
This is the relevant part of the change in this file, I ran prettier command before committing which made lots of formatting changes
akshay-gupta7
commented
Jun 12, 2024
| <Stack gap={2} direction="column"> | ||
| {Object.entries(internalEditToken.schema.schemas.value.properties ?? {}).map(([key], keyIndex) => ( | ||
| <> | ||
| <React.Fragment key={`border-input-fragment-${seed(keyIndex)}`}> |
There was a problem hiding this comment.
There was a react child unique key error, hence I replaced the blank fragment with a React Fragment(with a key)
akshay-gupta7
commented
Jun 12, 2024
Comment on lines
+68
to
+73
| if (mode === 'alias' && typeof internalEditToken.value === 'string') { | ||
| setBorderValue(selectedToken?.rawValue ?? {}); | ||
| } | ||
| setMode(mode === 'input' ? 'alias' : 'input'); | ||
| setAlias(''); | ||
| }, [mode]); | ||
| }, [mode, selectedToken, internalEditToken, setBorderValue]); |
There was a problem hiding this comment.
The pertinent change in this file. Lots of prettier formatting in this file as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2823