Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace iovec with std::io::IoSlice #224

Closed
carllerche opened this issue Aug 31, 2018 · 3 comments · Fixed by #263
Closed

Replace iovec with std::io::IoSlice #224

carllerche opened this issue Aug 31, 2018 · 3 comments · Fixed by #263
Milestone
v0.5

Comments

@carllerche
Copy link
Member

This would allow avoiding the additional dependencies.
@carllerche carllerche added this to the v0.5 milestone Aug 31, 2018
@carllerche carllerche changed the title Make iovec a feature Make iovec support a feature flag Sep 6, 2018
@carllerche
Copy link
Member Author

This would be in conflict with #63

@archseer
Copy link

archseer commented Jun 7, 2019

IoVec was stabilised as IoSlice in 1.36, so we can probably drop the iovec dependency and use the std types.

@seanmonstar
Copy link
Member

Yep, the plan with 0.5 is to switch to std's IoSlice.

@seanmonstar seanmonstar changed the title Make iovec support a feature flag Replace iovec with std::io::IoSlice Jun 7, 2019
@seanmonstar seanmonstar mentioned this issue Jun 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5
Development

Successfully merging a pull request may close this issue.

Replace iovec with std::io::IoSlice tokio-rs/bytes
3 participants
@carllerche @seanmonstar @archseer