Dynamic retention #502
Closed
grahamking
started this conversation in
Ideas
Replies: 1 comment
-
Moved to #503 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Currently the default retention period is 1 hour. That can easily grow to more than the max grpc message size (4 MiB), at which point tokio-console won't connect. Examples of people hitting this:
console_subscriber
#184We could make the default less than 1 hour, but there's really no minimum safe duration for retention. It depends on how busy the app is and on how much trace data runtime and tokio log.
Instead, we could make the retention period dynamic by shrinking it if the message is too big. I am thinking of a utility function called from
add_instrument_subscription
andpublish
that divides retention in half until the update fits in a message. Pseudo-code:Would you be open to a PR that makes the retention period dynamic like this?
Beta Was this translation helpful? Give feedback.
All reactions