Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New crate 1.16.0 has panic in take.rs #4435

Closed
kitsuneninetails opened this issue Jan 28, 2022 · 4 comments · Fixed by #4437
Closed

New crate 1.16.0 has panic in take.rs #4435

kitsuneninetails opened this issue Jan 28, 2022 · 4 comments · Fixed by #4437
Labels
A-tokio Area: The main tokio crate C-bug Category: This is a bug. M-io Module: tokio/io

Comments

@kitsuneninetails
Copy link

Version
1.16.0

Platform
Linux (local machine and in CircleCI)

Description
Panic in take under certain circumstances (using rocket):

thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `0x56193d9ed894`,
 right: `0x56193d9ed890`', /usr/local/cargo/registry/src/git.luolix.top-1ecc6299db9ec823/tokio-1.16.0/src/io/util/take.rs:93:9

Apologies, we are using "rocket" webserver, so this isn't a minimal test case.

@kitsuneninetails kitsuneninetails added A-tokio Area: The main tokio crate C-bug Category: This is a bug. labels Jan 28, 2022
@kitsuneninetails kitsuneninetails changed the title New crate 1.16.0 has major bug in "take" code in io.rs New crate 1.16.0 has panic in "take" code in io.rs Jan 28, 2022
@kitsuneninetails kitsuneninetails changed the title New crate 1.16.0 has panic in "take" code in io.rs New crate 1.16.0 has panic in take.rs Jan 28, 2022
@kitsuneninetails
Copy link
Author

kitsuneninetails commented Jan 28, 2022

I don't know the rocket usage under the covers that might isolate the specific usage of this take function. We do not use take directly in our code.

@LEXUGE
Copy link

LEXUGE commented Jan 28, 2022

I can reproduce here.

@Darksonn Darksonn added the M-io Module: tokio/io label Jan 28, 2022
@Darksonn
Copy link
Contributor

Sorry about that. It will be fixed by #4437, which I will release as soon as possible.

@Darksonn
Copy link
Contributor

We are currently preparing a release in #4438.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate C-bug Category: This is a bug. M-io Module: tokio/io
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants