You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This change was made because shutdown isn't safe to call in some contexts, or it might cause the original issue. It seems that the current shutdown function should be marked unsafe, because the code hasn't changed, and you can still call it in a way that causes the program to go wrong. Rust conventions seem to indicate this should be marked unsafe.
Version
>= 1.8.1
Platform
Linux system76-pc 6.2.6-76060206-generic #202303130630~1689015125~22.04~ab2190e~dev-Ubuntu SMP PREEMPT_DY x86_64 x86_64 x86_64 GNU/Linux
(any)Description
The
shutdown
function not properly markedunsafe
.I've been looking at some past bugs in tokio, and came across #3929 where
abort
changed from callingshutdown
toremote_abort
.tokio/tokio/src/runtime/task/join.rs
Lines 193 to 197 in 8439494
This change was made because
shutdown
isn't safe to call in some contexts, or it might cause the original issue. It seems that the currentshutdown
function should be markedunsafe
, because the code hasn't changed, and you can still call it in a way that causes the program to go wrong. Rust conventions seem to indicate this should be markedunsafe
.tokio/tokio/src/runtime/task/raw.rs
Lines 233 to 236 in a0a58d7
This isn't a safety issue currently, but could cause one in the future.
The text was updated successfully, but these errors were encountered: