Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement task dumps for current-thread runtime. #5608
Implement task dumps for current-thread runtime. #5608
Changes from 32 commits
1222dfb
d9aa093
66cd9c9
206b3d4
b998f74
8a727a1
80dbaf7
c132b33
9c86604
306a547
725bf3f
c20af63
52c8ca9
fdc01e1
144f378
c824389
0c655bb
578c3c4
ac7fa6b
a246b11
a62f9ee
f695499
bb6990f
51d15f0
178bf74
0a8d240
b6d093a
1ff355b
9e0dd91
9a5e7fa
f536db5
d3cda94
a29974d
51f970f
8a8dceb
b0b1160
8318d93
0dc4b68
04bd5e1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is the test designed to test various combinations of flags, I suggest we also try with just
--cfg tokio_unstable
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would trigger this compile error even without
rt
. You aren't going to be enabling--cfg tokio_taskdump
without knowing about it. Possibly also compile-fail on--cfg tokio_taskdump
without rt.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, unfortunately, this causes both a CI failure an a usability issue: You might just keep
--cfg tokio_unstable --cfg tokio_taskdump
in your environment (.cargo/config makes this easy to do), but not always want to actually use the taskdumping feature. In such scenarios, your build will fail because of the explicitcompile_error!
.Consequently, I've reverted my attempt at adding this compile_error: 8318d93
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One possible improvement here is to use impl Trait to simplify the definition of methods that return iterators. For example:
'_ means that the lifetime of the returned iterator is bound to the lifetime of the Tasks object