rt: move Inject to runtime::scheduler
#5748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `Inject` was defined in `runtime::task`. This was because it used some internal fns as part of the intrusive linked-list implementation. In the future, we want to remove the mutex from Inject and move it to the scheduler proper (to reduce mutex ops). To set this up, this commit moves `Inject` to `runtime::scheduler`. To make this work, we have to `pub(crate)` `task::RawTask` and use that as the interface to access the next / previous pointers.
carllerche
added
C-maintenance
Noah-Kennedy
approved these changes
Jun 1, 2023
Darksonn
approved these changes
Jun 1, 2023
|
CI is spuriously failing. #5752 attempts to resolve the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
Injectwas defined inruntime::task. This was because it used some internal fns as part of the intrusive linked-list implementation.In the future, we want to remove the mutex from Inject and move it to the scheduler proper (to reduce mutex ops). To set this up, this commit moves
Injecttoruntime::scheduler. To make this work, we have topub(crate)task::RawTaskand use that as the interface to access the next / previous pointers.