Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tracing-etw to win_etw_tracing #2504

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hrxi
Copy link
Contributor

@hrxi hrxi commented Mar 11, 2023

This git repository of tracing-etw is gone, the crate (which only ever had one version) is yanked. win_etw_tracing seems to be a new crate that implements the same thing.

@hrxi
Copy link
Contributor Author

hrxi commented Jun 19, 2023

Rebased. Anything I need to do to get this merged?

@hawkw
Copy link
Member

hawkw commented Jun 19, 2023

I believe #2602 fixed this as well --- the crate appears to have moved to a different repository.

@hrxi
Copy link
Contributor Author

hrxi commented Jun 19, 2023

I believe #2602 fixed this as well --- the crate appears to have moved to a different repository.

Ah, it was only changed in one place. The crate seems unrelated (EDIT: the original crate is still completely yanked), should I update the references to the repository everywhere?

@hawkw
Copy link
Member

hawkw commented Jun 19, 2023

Yes, that would be great, thank you!

This git repository of `tracing-etw` is gone, the crate (which only ever
had one version) is yanked. `win_etw_tracing` seems to be a new crate
that implements the same thing.
@hrxi hrxi changed the title Remove tracing-etw link Change tracing-etw to win_etw_tracing Jun 19, 2023
@hrxi
Copy link
Contributor Author

hrxi commented Jun 19, 2023

Done.

@Robo210
Copy link

Robo210 commented Jul 19, 2023

For what it's worth, we (the Microsoft ETW team) are working on a new tracing-etw crate, and don't recommend the win_etw_tracing crate because it does not follow best practices for ETW (and is Windows-only). It may be better to just remove mention of ETW entirely and then we will make a new PR to add it back when the new crate is ready (probably next month).

@hrxi
Copy link
Contributor Author

hrxi commented Jul 19, 2023

Seems like your crate could also be included then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants