-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change tracing-etw
to win_etw_tracing
#2504
base: master
Are you sure you want to change the base?
Conversation
Rebased. Anything I need to do to get this merged? |
I believe #2602 fixed this as well --- the crate appears to have moved to a different repository. |
Ah, it was only changed in one place. The crate seems unrelated (EDIT: the original crate is still completely yanked), should I update the references to the repository everywhere? |
Yes, that would be great, thank you! |
This git repository of `tracing-etw` is gone, the crate (which only ever had one version) is yanked. `win_etw_tracing` seems to be a new crate that implements the same thing.
Done. |
For what it's worth, we (the Microsoft ETW team) are working on a new tracing-etw crate, and don't recommend the win_etw_tracing crate because it does not follow best practices for ETW (and is Windows-only). It may be better to just remove mention of ETW entirely and then we will make a new PR to add it back when the new crate is ready (probably next month). |
Seems like your crate could also be included then. |
This git repository of
tracing-etw
is gone, the crate (which only ever had one version) is yanked.win_etw_tracing
seems to be a new crate that implements the same thing.