Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype views seem to have a global namespace #8

Closed
tbrannam opened this issue Oct 24, 2014 · 2 comments
Closed

Prototype views seem to have a global namespace #8

tbrannam opened this issue Oct 24, 2014 · 2 comments

Comments

@tbrannam
Copy link
Contributor

On IOS UITableview and UICollectionView both seem to have a reuseIdentifier registry specific to the instance.

I would think that ISSViewHierarchParser should not call [[InterfaCSS interfaCSS] registerPrototype:currentPrototype]; but instead call UITableView/UICollectionView registerClass:reuseIdentifier:

I think there are still issues related to issue #7 which may require something more dynamic.

@tbrannam
Copy link
Contributor Author

tbrannam commented Nov 3, 2014

I see that this has been changed somewhat - although I still find it surprising that Cell prototypes are not namespaced to their containing view. This would mirror the behavior of [UITableView/UICollectionView registerClass:reuseIdentifier:] little better.

@tolo
Copy link
Owner

tolo commented Nov 3, 2014

Well, I guess the reason for this was that the concept of prototypes is not limited to just tableview/collectionview cells. But I can understand that it sometimes can make life easier if the prototype was scoped/namespaced under a containing view. Adding this in the next commit.

@tolo tolo closed this as completed in 8994f1c Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants