Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading state/Background Color #17

Closed
masiamj opened this issue Jun 18, 2019 · 7 comments
Closed

Loading state/Background Color #17

masiamj opened this issue Jun 18, 2019 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@masiamj
Copy link

masiamj commented Jun 18, 2019

Hey @tomLadder, first off, awesome library! Love using it, and it's been a huge help.

I'm curious how you handle loading states before the chart actually renders? I'm having a tough time with it right now and was wondering if we (happy to put in a PR) could implement a loading-type callback or be able to change the background color (on html, body, or main pre-render via props.

Let me know, happy to contribute!

@tomLadder
Copy link
Owner

Hey @masiamj !
Thanks for very much for your feedback 🙏

First of all, I forgot to add the onLoadEnd callback to the documentation. It fires when the WebView finished loading the echarts framework.

The feature request to set a custom background color totally makes sense 👍 Probably the easiest and most efficient solution would be to inject a custom javascript function which sets the background color with some DOM Manipulation. The background-color could be a property of the ECharts component.
When the WebView finished the loading (onLoadEnd) of the local files you could check if there is a custom color set with a property and then call the injected javascript function to set it.

Cheers
Tom

@tomLadder tomLadder added the enhancement New feature or request label Jun 19, 2019
@ty-sang
Copy link

ty-sang commented Aug 16, 2019

Nice Library, and thanks for all the supports!

May I ask about the timeline for this request? I'm trying to change background color and match design. Thank again!

@tomLadder
Copy link
Owner

Hey @SHIEER.
Gonna have a look at it tomorrow.

Cheers
Tom

@tomLadder
Copy link
Owner

Just released v1.4.5 🎉.
Adds backgroundColor support.

@ty-sang
Copy link

ty-sang commented Aug 21, 2019

@tomLadder Just wanna say thank you! I'm new to React Native, and I like to improve this wrapper along I'm using it. Thanks a lot!

@tomLadder
Copy link
Owner

@SHIEER Thank you! Your welcome to send some nice pull requests :)

@namcu1998
Copy link

namcu1998 commented Jul 6, 2023

Can the background color is transparent?
and where can I edit text color?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants