"Remote end closed socket abruptly" Node.js 12.16.3

[ivanstanev]

Hey! The new patch release of Node.js (12.16.3) broke needle (we're using 2.4.0) and using needle with redirects now causes the following error:

Error: Remote end closed socket abruptly.
    at TLSSocket.on_socket_end (/Users/ivan/local/node_modules/needle/lib/needle.js:473:17)
    at processTicksAndRejections (internal/process/task_queues.js:79:11)

You can reproduce it with the following piece of code:

await needle('get',
  `https://github.com/kubernetes-sigs/kind/releases/download/v0.7.0/kind-linux-amd64`,
  null,
  { follow_max: 2 },
);

A similar issue was raised a while ago here: #261

[tomas]

Darn. Do you know what did the Node.js release change regarding TLS sockets?

[gitphill]

https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V12.md#12.16.3, Updated OpenSSL to 1.1.1g?

[tomas]

Will take a look at this later today.

[ronag]

nodejs/node#33254

[ronag]

This condition looks wrong.

It worked before due to bug in Node that was fixed in nodejs/node@ed21d32#diff-e6ef024c3775d787c38487a6309e491dL634, which then broke needle.

Basically, just because the socket has 'end':d and is no longer writable does not mean it has to be destroyed. It get's destroyed after it has been shutdown.

If you want to detect a premature close please take look at hows eos or the native stream.finished module does it.

[tomas]

Good call @ronag. So we should remove that check altogether?

[ronag]

Good call @ronag. So we should remove that check altogether?

Yes. Use response.on('aborted', handler) instead.

[mhio]

Wow.. this has been driving me crazy for a week.

For some reason the issue seems to be exacerbated by builds that were running in a CI container. I couldn't reproduce the issue in a local docker build FROM node:12.16.3 container, but running the yarn install in a kaniko or buildah container node-pre-gyp downloads using needle would fail with the Remote end closed socket abruptly error every time.

[zbjornson]

Sorry to pester, but any chance this can be resolved soon? We're getting a lot of issues opened in node-canvas because our prebuilds are failing to download. Thank you!

[tomas]

@zbjornson Looking at it right now. Sorry for the delay.

[tomas]

Ok looks like I found a fix. Once I get the last three specs to pass on Node v12.16.3 I'll push a new version.

[marcosflick]

Any updates on this?

[tomas]

Yes! I'll push a new version in a while.

[tomas]

Ok we're good to go.

[tomas]

Just pushed 2.5.0 which fixes this issue.

Sorry everyone for the long delay -- I run an ecommerce platform and these past weeks have been a bit crazy.

PS: @ronag I tried the aborted callback or the stream.finished route but they didn't work, so I ended up adding an simple check that does the trick, while still handling the scenario tested in test/long_string_spec.js. Feel free to submit a PR if you find a better strategy though. :)

[darscan]

@tomas Thanks for the fix. Working on open source can be a pretty thankless business sometimes, but your work here is much appreciated 😃