Merged abstract syntax tree #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tomblachut
force-pushed
the
feature/merged-ast
branch
from
e849905 to
fad1c35
Compare
tomblachut
force-pushed
the
feature/merged-ast
branch
from
57d5529 to
e48543f
Compare
tomblachut
force-pushed
the
feature/merged-ast
branch
6 times, most recently
from
e18286d to
461e878
Compare
tomblachut
force-pushed
the
feature/merged-ast
branch
8 times, most recently
from
09ea4f5 to
590aa31
Compare
|
as far as I can see tests don't work. It can be fixed by adding missing dependency 'platform-images'. |
|
@anstarovoyt interesting, thanks. Can you point me to some resource what this plugin is responsible for? |
CSS depends on 'platform-images' and the 'platform-images' is an "internal" plugin. It isn't obvious and it will be fixed in the Gradle plugin in the future. |
|
@tomblachut Why did you change SvelteHtmlFile super class from HtmlFileImpl to JSFileImpl? I believe the solution with HtmlFile is more "correct". Also, it works in the same way for e.g. Vue and the solution looks viable. |
tomblachut
force-pushed
the
feature/merged-ast
branch
6 times, most recently
from
dd70cac to
5e9be64
Compare
tomblachut
force-pushed
the
feature/merged-ast
branch
from
3e34e25 to
e9bf8a6
Compare
tomblachut
force-pushed
the
feature/merged-ast
branch
from
e9bf8a6 to
311c444
Compare
|
Defo longest living branch in my whole career 😅 |
This was
linked to
issues
Jul 30, 2020
Closed
|
@tomblachut awesome! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm really happy about this PR number.
Resolves #19
TODO: