Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap for 1.0 #3

Open
3 tasks
tomchentw opened this issue Sep 26, 2015 · 7 comments
Open
3 tasks

Roadmap for 1.0 #3

tomchentw opened this issue Sep 26, 2015 · 7 comments
Milestone

Comments

@tomchentw
Copy link
Collaborator

Todos

  • How about this.refs and this.context?
  • shouldComponentUpdate
  • Custom functions on Component.prototype

Please feel free to leave any thoughts in this thread.

@tomchentw tomchentw added this to the v1.0 milestone Sep 26, 2015
@sergey-lapin
Copy link

@tomchentw Hi! Awesome idea! I builded https://github.com/lapanoid/redux-cropper with this approach independently and wanted to extract some code in separate project, but found out your project in npm. Really want to help, now reading your code. First thing that I really want is 'passing props api' for redux-component so it could be used as usual react component, the idea is that end user should not be aware that we use redux internally. What do you think?

@tomchentw
Copy link
Collaborator Author

@Lapanoid I recently found the idea behind redux-component could be largely leveraged by recompose. Like to hear your feedback on this though.

What do you mean for 'passing props api'? With Componentize of redux-component, the resulting component class is unware of redux's existence so the user will not aware this.

@sergey-lapin
Copy link

@tomchentw I think my goal is different, in general I want redux app to be accessible as react component, and as far as I understand you 'reduxify' some pure components. It is like moving in opposite directions.

@tomchentw
Copy link
Collaborator Author

Got it. So this is what you're talking about:
https://github.com/lapanoid/redux-cropper/blob/master/src/index.js

That's correct. It's in the opposite direction. Just curious, have you read this?
https://github.com/erikras/ducks-modular-redux

@sergey-lapin
Copy link

@tomchentw Yes I saw that, this give some modularity within one application. I want something different, some components is too complex, so to reason about them we can use redux, so I basically want to use redux within redux much like Dan's idea for redux-devtools, problem that in the end I will have app which is hard to compose elsewhere, so I build this lib to convert redux app into react component. Docs is pretty awful right now, working on that.

@tomchentw
Copy link
Collaborator Author

Didn't quite get it. If you can use the generated Cropper React component without the knowledge of redux existence in here, then I think the concept for redux-as-component is aligned with redux-component. But that differentiates what you mentioned above. Did I get something wrong?

@sergey-lapin
Copy link

From this point I guess so, we both have react component as the result. But as far as I understood you rely on pure functions and pure components all the way, but my goal is to convert arbitrary redux app to component without any limitations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants