feat(src): switch to use lodash directly

tomchentw · May 30, 2016 · 304f465 · 304f465
1 parent 5db33f9
commit 304f465
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 19 deletions.
diff --git a/src/GoogleMapLoader.js b/src/GoogleMapLoader.js
@@ -1,3 +1,5 @@
+import _ from "lodash";
+
 import {
   default as React,
   PropTypes,
@@ -30,10 +32,7 @@ export default class GoogleMapLoader extends Component {
     if (this.state.map || domEl === null) {
       return;
     }
-    const {
-      children, // eslint-disable-line no-unused-vars
-      ...restProps,
-    } = this.props.googleMapElement.props;
+    const restProps = _.omit(this.props.googleMapElement.props, [`children`]);
     //
     // Create google.maps.Map instance so that dom is initialized before
     // React's children creators.

diff --git a/src/async/ScriptjsLoader.js b/src/async/ScriptjsLoader.js
@@ -1,3 +1,5 @@
+import _ from "lodash";
+
 import {
   default as React,
   Component,
@@ -101,16 +103,7 @@ Changed props: %s`,
   render() {
     if (this.state.isLoaded) {
       if (this.shouldUseNewBehavior()) {
-        const nextProps = Object.keys(this.props).reduce((acc, key) => {
-          if (DELEGATE_PROPS_LIST.indexOf(key) !== -1) {
-            return acc;
-          } else {
-            return {
-              ...acc,
-              [key]: this.props[key],
-            };
-          }
-        }, {});
+        const nextProps = _.omit(this.props, DELEGATE_PROPS_LIST);
 
         return (
           <GoogleMapLoader

diff --git a/src/utils/makeUrl.js b/src/utils/makeUrl.js
@@ -1,3 +1,5 @@
+import _ from "lodash";
+
 import {
   format as formatUrlObj,
 } from "url";
@@ -6,10 +8,6 @@ import {
   PropTypes,
 } from "react";
 
-import {
-  default as isEqual,
-} from "lodash.isequal";
-
 export default function makeUrl(urlObj) {
   return formatUrlObj({
     protocol: urlObj.protocol,
@@ -32,5 +30,5 @@ export const urlObjDefinition = {
 
 export function getUrlObjChangedKeys(urlObj, nextUrlObj) {
   return Object.keys(urlObjDefinition)
-    .filter(key => !isEqual(urlObj[key], nextUrlObj[key]));
+    .filter(key => !_.isEqual(urlObj[key], nextUrlObj[key]));
 }