Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Showing componentWillMount deprecated warnings . #1002

Open
vineet-agrawal96 opened this issue Aug 14, 2019 · 6 comments · May be fixed by #1056
Open

Showing componentWillMount deprecated warnings . #1002

vineet-agrawal96 opened this issue Aug 14, 2019 · 6 comments · May be fixed by #1056

Comments

@vineet-agrawal96
Copy link

How to fix this following warnings. I'm sure we are not using anywhere componentWillMount method in our project.

breadcrumbs.js:76 Warning: componentWillMount has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

  • Move code with side effects to componentDidMount, and set initial state in the constructor.
  • Rename componentWillMount to UNSAFE_componentWillMount to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run npx react-codemod rename-unsafe-lifecycles in your project source folder.

Please update the following components: withGoogleMap(Component)
@JustFly1984
Copy link

this project is unmaintained more than a year, please look at @react-google-maps/api

@KevinBurton
Copy link

Is there a similar React component that is more actively maintained?

@JustFly1984
Copy link

@KevinBurton
The repo of this project is unmaintained more than a year, and we had build new version https://www.npmjs.com/package/@react-google-maps/api

We had rewrite it to TypeScript, and updating it frequently: https://github.com/JustFly1984/react-google-maps-api/tree/master/packages/react-google-maps-api
You can enjoy autocomplete.

You can see our docs: https://react-google-maps-api-docs.netlify.com/

Also a lot of examples: https://react-google-maps-api-gatsby-demo.netlify.com/ https://github.com/JustFly1984/react-google-maps-api/tree/master/packages/react-google-maps-api-gatsby-example/src/examples

The bundle size is much smaller: https://bundlephobia.com/result?p=@react-google-maps/api@1.7.7

Our Spectrum community: https://spectrum.chat/react-google-maps

Enjoy!


@NitnekB
Copy link

NitnekB commented Jan 14, 2020

Hello!

Thanks for those informations @JustFly1984
Nevertheless, it was too late for me when I discovered this project is no longer maintain :S
Can I suggest to add this precious information directly on README?

I already prepared a PR for this: #1028

Many thanks!

@JustFly1984
Copy link

@NitnekB it is not possible to add PR, cos PR could be merged only by owner, who disagreed 2 years ago. Your PR is useless, nobody can't merge it. Consider to switch to my library.

@NitnekB
Copy link

NitnekB commented Jan 15, 2020

Good to know, thx!

Too bad for this though. Other people will probably make the same mistake.. 😕

Anyway, thank you for your lib 👍

@vzaidman vzaidman linked a pull request Sep 9, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removed the deprected componentWillMount 10bis/react-google-maps
4 participants
@JustFly1984 @KevinBurton @NitnekB @vineet-agrawal96