Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call for maintainers. I need your help #266

Open
tomchentw opened this issue May 27, 2016 · 39 comments
Open

Call for maintainers. I need your help #266

tomchentw opened this issue May 27, 2016 · 39 comments

Comments

@tomchentw
Copy link
Owner

tomchentw commented May 27, 2016

For anyone interested, feel free to jump in answering questions on StackOverflow first:
https://stackoverflow.com/search?tab=newest&q=react-google-maps

General Reply Template

I cannot see there's a relationship with your issue with `react-google-maps`. Please submit a minimal repository to reproduce your issue if you really want some help.

---

I understand this is frustrated, but this is not a support form on how to use Google Maps API. `react-google-maps` is simply a wrapper around it. Unless there's a specific issue on the `react-google-maps` itself, please post your questions on StackOverflow instead of creating an issue here.

The maintainers only have limited time on open source projects. Please help us keep the health ecosystem. Thanks!
@cristiandley
Copy link
Collaborator

You have my sword on this path! 😄

@rewop
Copy link
Collaborator

rewop commented May 27, 2016

I can help, also due to the fact I got to know the module a little bit better lately.

@tomchentw
Copy link
Owner Author

tomchentw commented May 29, 2016

Maintainers list

@tiagomegas
Copy link

@tomchentw I'm thinking on helping you out too! And let me add that you when you say no project uses in production...we use it here: www.flykt.com !!! And I love it ^^

@tomchentw
Copy link
Owner Author

@tiagomegas thanks. Check out 6.0.0 which is released on npm beta tag now. We also have a new demo page. Feel free to try it:
https://tomchentw.github.io/react-google-maps/

@thzinc
Copy link

thzinc commented Jan 12, 2017

I'd be interested in helping to maintain this project. At Syncromatics, we're building out a new version of our site on top of this, and I'd like to be able to contribute improvements and help do the work of maintaining the codebase. How can I go about contributing? (I do already have a PR out for adding TrafficLayer)

(CC @wuct @cristiandley @rewop)

@jsmapr1
Copy link

jsmapr1 commented Jan 17, 2017

Happy to help also. I'm going to be using the project heavily for at least the next year so I'lll be around quite a bit.

@harlannorth
Copy link

I work with @thzinc over at Syncromatics and as he mentioned we're using react-google-maps for the next version of our UI, so I'd like to contribute where I can as well.

@oshalygin
Copy link
Collaborator

Happy to help guys. Going to be using this or something very close to it over the next couple of years.

@yoihito
Copy link

yoihito commented Feb 20, 2017

Hi guys. I would like to help you with it, going to use the project for the next year or so :)

@oshalygin
Copy link
Collaborator

Ive got other commitments but I havent heard back from the author(no email response :( ), I'll be ramping up on this again come March if anyone wants to fork and continue

@oshalygin
Copy link
Collaborator

Hey guys, there are a series of PR's that we can merge in and keep contributing to the project. @tomchentw any chance you can grant me access?

@stereobooster
Copy link

There are 4 options for React Google maps. I created gist to compare them https://gist.github.com/stereobooster/13a26188d4ad5382bc6da9ffe76ce3e1. None of them actively supported :/.

@pkill37
Copy link

pkill37 commented Apr 1, 2017

@stereobooster Yeah, because of that I ended up using react-leaftlet, which is well documented and fairly active. I may reconsider and go down the D3 route.

@ZaynMalloc
Copy link

Hello, I would like to help out!

@shinzui
Copy link

shinzui commented Jul 23, 2017

What's the status of this?

@oshalygin
Copy link
Collaborator

of which @shinzui ? We are still looking for maintainers and pushing the project forward. @tomchentw has actually been fairly active helping out quite a bit.

@shinzui
Copy link

shinzui commented Jul 24, 2017

@oshalygin, sorry for the vague question. I'm picking a library to integrate google maps into my react app and saw the call for maintainers in the readme linking to this issue. The issue was opened 15 months ago so I was wondering if the project is going to have a maintainer steering it forward.

@oshalygin
Copy link
Collaborator

@shinzui There are a number of maintainers that are keeping the project alive and we are constantly releasing new features with the help of the community 👍

Once we get some of the bigger pieces together with the project we'll cleanup the README a bit to remove ambiguity 💯

@sudheerDev
Copy link

@oshalygin Are there any API docs?. All I could see are examples and with recompose. For example, i am trying to figure out what withScriptjs does. Digging into the source for every import is an over kill.
API Documentation would be great and if possible library agnostic examples.

@tomchentw
Copy link
Owner Author

@sudheerDev the API docs for a component is documented in the react-styleguidist site. Click "PROPS & METHODS" to open it. Basically, you can see it's a simple delegation to the Google Maps JavaScript API.
https://tomchentw.github.io/react-google-maps/#!/GoogleMap

screenshot-2017-9-15 googlemap react google maps style guide

Yeah, currently we don't have docs for withGoogleMaps and withScriptjs, but the examples should be self-explainable. Please feel free to contribute the docs into the repo.

@sudheerDev
Copy link

@tomchentw Aah ok. Thanks. Just took time to figure out from examples, issues that few are components and few are higher order functions. Logs helped though

Nice work with the repo!

@tomchentw
Copy link
Owner Author

For anyone interested, feel free to jump in answering questions on StackOverflow first:
https://stackoverflow.com/search?tab=newest&q=react-google-maps

@urikphytech
Copy link
Contributor

Hi! What's the status on this issue? I'm currently working on a fork of the project but would be happy to be added as a maintainer/contributer instead.

@JustFly1984
Copy link

I'm also working on the fork, it will be ready this week, it does supports last API version, does not have componentWillMount - it uses getDerivedStateFromProps, does support all new features, and properly typed with prop-types (look ma, no PropTypes.any!), supports to load unlimited number of maps on the same page, has no lodash in dependencies and very lightweight and performant. I will publish it soon.

@JustFly1984
Copy link

@urikphytech if you want to join, I can give you access to the repo.

@urikphytech
Copy link
Contributor

urikphytech commented Nov 28, 2018

@JustFly1984 That sounds amazing! I'd be glad to get access and help out with your open issues/tasks. I did some work on switching to the new context API, but right now it depends on react v16.5 because it's using Class.contextType.

This is actually my work account, better invite @uriklar which is my personal account

@JustFly1984
Copy link

@urikphytech new context api doesn't help if you need multiple maps on the same page. I've fixed this issue. I will add you to collaborators. Please do your changes in separate branch, and make pull requests. Do you have skype or something?

@JustFly1984
Copy link

JustFly1984 commented Nov 28, 2018

@urikphytech I've added you to collaborators, lets continue conversation here https://github.com/JustFly1984/react-google-maps-api/invitations

It is private repo, cos I use my own key to test development. There is an example build on gatsby (so I could test SSR later on)

@lucifer1004
Copy link

I am working on a new React wrapper for Google Map API, based on the latest React features: hooks, context...
The library has only three direct dependencies: react, react-dom and loadjs

Current status:

  • MapBox
  • Marker
  • InfoWindow
  • Polygon
  • HeatMap
  • OverlayView

Highlights:

  • No class components
  • Highly flexible. Components can be put anywhere inside the context, which makes it much easier to implement complicated interactions or logic.
  • 100% coverage (not that good, using many mocks)

@urikphytech @JustFly1984 it is possible to have multiple maps on the same page with context. You only need to use multiple contexts.

My Repo
APIs are not fully stable yet, and I hope more people can join.

@JustFly1984
Copy link

@lucifer1004 we have a stable API at @react-google-maps/api

@urikphytech
Copy link
Contributor

urikphytech commented Feb 13, 2019

Btw you can check out the hooks branch. It has a working poc of the useMapComponent hook

We would love you to join us! We want to start adding test as well soon so it would be great to get you on board working on that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests