Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sheets with component instances do not save when instance ports change #130

Closed
tomcl opened this issue Jan 30, 2022 · 2 comments
Closed

Sheets with component instances do not save when instance ports change #130

tomcl opened this issue Jan 30, 2022 · 2 comments
Labels
done!

Comments

@tomcl
Copy link
Owner

tomcl commented Jan 30, 2022

Any change to the ports of a sheet can be propagated to all existing components via a dialog, which is always used. However, the changes do not get automatically saved because Issie does not know there has been any change.

That means after changing ports on a sheet you must navigate to pages with instances of teh sheet, move something to make the sheet saveable, and save it. This should be fixed.
@tomcl tomcl added the bug Something isn't working label Jan 30, 2022
@tomcl
Copy link
Owner Author

tomcl commented Feb 4, 2022

closed again with v2.4.3 (tag 2.4.3.1)

This time let's hope it all works.

@tomcl tomcl added done! and removed bug Something isn't working labels Feb 4, 2022
@tomcl tomcl closed this as completed Feb 4, 2022
@tomcl tomcl reopened this Feb 6, 2022
@tomcl
Copy link
Owner Author

tomcl commented Feb 6, 2022

Not quite done above, Now fixed in v2.4.4

@tomcl tomcl closed this as completed Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
done!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomcl