Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components are renamed in the properties tab when their name is numeric #144

Closed
1rre opened this issue Mar 8, 2022 · 2 comments
Closed

Comments

@1rre
Copy link

1rre commented Mar 8, 2022

When a nameable component (such as a wire label, input or output) is given a purely numeric name (ie 4) upon adding the component, the circuit diagram shows their name as entered, however in the properties tab, all these components are given the name L in the Properties tab, but their numeric name for all other purposes.

When editing the name of a component in the Properties tab, a numeric value is not saved as the name of the component.
If this is to prevent components being given numeric names, a message should show when the user attempts to name their component a numeric value both when creating the component or when editing its properties. If a user is allowed to give components numeric names, then the given numeric name should show in the Properties tab and the name the user gives the component in the Properties tab should be saved.

@tomcl
Copy link
Owner

tomcl commented Mar 8, 2022

OK, the problem here is pure numeric names which should be disallowed.
Quick to fix but not high priority so will do after Term ends

@tomcl
Copy link
Owner

tomcl commented Apr 16, 2022

Closed for now, since it should be solved. Component names are due to be revisited some time for a better solution.

@tomcl tomcl closed this as completed Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants