Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waveform Simulation - perform waveform SVG creation in background #299

Closed
tomcl opened this issue Jul 14, 2023 · 1 comment
Closed

Waveform Simulation - perform waveform SVG creation in background #299

tomcl opened this issue Jul 14, 2023 · 1 comment
Assignees

Comments

@tomcl
Copy link
Owner

tomcl commented Jul 14, 2023

The waveform SVGs take some time to generate. Currently when waveforms are selected the generation happens immediately which leads to an unresponsive selector when a large number of waveforms are selected at once.

Also, when waveforms are scaled or panned , more generation is sometimes needed, which again takes time and makes the simulation view unresponsive. (Though this is probably less annoying than the selector).

Both problems can be solved by:

  • Creating wavefom SVGs as a sequence of separate "create next batch of SVGs" messages each no longer than say 50ms
  • Scheduling any outstanding SVG creation after small gap of say 10ms. This will allow other events to be processed and screen to update
  • For the case where not all SVGs have been created and the waveforms are visible display those that are created with white screen for those that have not yet been created. (Mayeb it would be less distracting to display the old SVG, if this exists, TBC).

This issue is linked to #298

@tomcl
Copy link
Owner Author

tomcl commented Jul 24, 2023

see also #332 - it turns out that SVG creation is at the moment very inefficient an can quite easily be speeded up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants