Some fix of netref + a better implementation of the ThreadPoolServer

[sponce]

Note that only 2 commits are to be pulled out of the 7, I do not quite get why github insists in listing the 7, and in particular the merge. Anyway :

• one fixes a subtle issue in netref, where a weak reference has become invalid when you try to use it. This leads to "NoneType has no attribute..." errors when using async requests under load
• the other is a (much) better implementation of the ThreadPoolServer (see log message for details).

[tomerfiliba]

bb0948b: merged

d4b26b9: i see you're using select.poll, so this code won't run on windows. could you change it to select.select instead? that way it would be cross-platform.

57fe482: i'd guess d4b26b9 overrides this commit?

[sponce]

d4b26b9: i see you're using select.poll, so this code won't run on windows.
Well, indeed (just read the doc...). Not that I would try to run a high performance server on windows :-)
I'll see what I can do. The problem is I cannot test under windows anyway and the tests under linux were all done with poll. And these are not at all easy to do (they especially involved quite some hardware) so I will have a hard time redoing them....

57fe482: i'd guess d4b26b9 overrides this commit?
Yes it does, I had forgotten that one. You forget it too :-)

[tomerfiliba]

don't worry about testing on windows too much -- testing it on linux is enough for me. i just want the code to be able to run on all platforms.

by the way -- you could write a "mock poll" object that relies on select when poll is not supported. e.g.

class MockupPoll(object):
    def register(self, fd, flags):
        if flags & select.POLLIN:
            self.rfds.append(fd)
        if flags & select.POLLOUT:
            self.wfds.append(fd)
    def poll(self, timeout):
        rfds, wfds = select.select(self.rfds, self.wfds, [], timeout)
        return unified list of fds and event mask

that way you can keep your code in tact and still be cross-platform.

[tomerfiliba]

@sponce, any news on that?

[tomerfiliba]

@sponce: i integrated your ThreadPoolServer. please review the commit (c1c3b5d) and rpyc/lib/compat.py. i replaced your wrappedPoll with a more functionally-complete mock.

could you write an automated test for it?

thanks for your help,
-tomer