Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform automatic retries for 410s during watches #136

Closed
JacobHenner opened this issue Feb 13, 2021 · 2 comments · Fixed by #327
Closed

Perform automatic retries for 410s during watches #136

JacobHenner opened this issue Feb 13, 2021 · 2 comments · Fixed by #327

Comments

@JacobHenner
Copy link
Contributor

At this time, when a watch expires (with a 410 Gone) the watcher returns an "error" event to the caller. Instead of returning a raw error event, it should attempt to resume the watch (as it would after a timeout). If that fails, it should raise an exception.

A similar change has been incorporated into the kubernetes-client/python library: kubernetes-client/python-base#133

See also:

@JacobHenner
Copy link
Contributor Author

I'm not sure I still agree with the change proposed originally. I'm going to think about it some more, and will update this issue once I have a better idea of what the desired behavior is (see discussion in the see also links).

@remram44
Copy link

remram44 commented Feb 7, 2022

I ran into this. I am trying to fix the bug, but it is hard to validate a fix since it takes a long time before a 410 gets returned by Kubernetes. An automatic retry in kubernetes-asyncio would be appreciated, especially since the sync kubernetes client has it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants