-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension does not support WSL #28
Comments
Hi @YannickMG Thanks for your thorough issue report. WSL is certainly a platform I had yet to test on. The symptoms you’ve given me suggest that the extension fails as the Indexer process starts to initialise by locating the package.json file. You’ve definitely taken all sensible steps and I appreciate you trying to create a log file. The log file would have been created in the root of your project as 'rename-angular-component-debug-log.txt'. But if it’s identifying the project file root when inside WSL that is the problem - as is likely from the symptom above, then it won’t have been able to create the file in the right place. I’ll get onto this shortly. |
Hi @tomwhite007 got same issue. Really hope you can fix it soon! |
Hi @DuckPluck |
Hi @YannickMG and @DuckPluck I have run some tests, and can confirm I know what's required to upgrade the process to work on WSL. The work is not trivial, so you can watch this PR for progress: Feat/use vscode workspace fs #31 . |
Thanks for the update. I would've thought that VS code would offer some standard API it also uses when dealing with remote environments, since it's a feature they advertise so much. |
Hello @YannickMG and @DuckPluck I put some proper time into the conversion to using It is with regret that I'm going to have to say, I can't support WSL. My apologies guys, you'll have to open your project on the Windows FS side to use the extension. It's not often I say no, but my hand is forced, sorry. |
No worries, thanks for looking into it. |
Describe the bug
After selecting a new name for a component/service in the extension's renaming dialogue, nothing visibly happens.
To Reproduce
Steps to reproduce the behavior:
Try using the extension in an angular application located in the WSL file system.
Expected behavior
At least a clear error message in the "Rename Angular Component" logs which only displays the following:
Screenshots or Demo Repo
In the dev tools, one can find the following error:
The application is in fact located at
~/app-name
in the Linux file system, but the extension tried to access the application's folder using a path that is relative to my Windows home folder.Desktop (please complete the following information):
Additional context
Unrelated but I also couldn't find a logs file to upload even after turning on the option to generate it. I might not have known where to look though.
The text was updated successfully, but these errors were encountered: