Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neovim syntax highlighting for FunC #88

Closed
1 task done
liketurbo opened this issue Dec 10, 2022 · 19 comments
Closed
1 task done

Neovim syntax highlighting for FunC #88

liketurbo opened this issue Dec 10, 2022 · 19 comments
Assignees
Labels
Approved This proposal is approved by the committee Developer Tool Related to tools or utilities used by developers Progress Blocked Task halted due to obstacles or issues

Comments

@liketurbo
Copy link
Contributor

liketurbo commented Dec 10, 2022

Summary

Add syntax highlighting for FunC to Neovim.

Context

Neovim is a fork of the venerable text editor Vim.
It is a popular editor among many developers and is used by some Unix distributions as their default editor.

Goals

  • Add syntax highlighting for FunC to Neovim.

Deliverables

  • Submit parser with at least highlight query file to nvim-treesitter repository

Definition of Done

Reward

  • Standard TON Footstep NFT
  • 250$ in TON equivalent
@liketurbo liketurbo added the footstep This is a TON Footstep issue label Dec 10, 2022
@coalus
Copy link
Contributor

coalus commented Dec 11, 2022

There is already a plugin for FunC syntax highlighting in NeoVim: https://github.com/cryshado/neovim-ton-dev

@liketurbo
Copy link
Contributor Author

liketurbo commented Dec 11, 2022

There is already a plugin for FunC syntax highlighting in NeoVim: https://github.com/cryshado/neovim-ton-dev

That's great 👍️

  1. Yes, it is already exists a parser for FunC, as I stated in the footstep.
  2. Yes, you can find instructions of how to enable it for your local environment, e.g Adding parsers

This footstep's purpose is to submit that existing parser to nvim-treesitter repository, so you can later add language support just by using :TSInstall <language_to_install>

@liketurbo
Copy link
Contributor Author

@akifoq can you do it, if it gets approved? Or without approval for free, if you feel generous 😄

@Naltox
Copy link

Naltox commented Dec 14, 2022

LGTM

@Gusarich Gusarich added the Approved This proposal is approved by the committee label Dec 14, 2022
@liketurbo
Copy link
Contributor Author

liketurbo commented Dec 15, 2022

Changed the reward, hope it's okay

100 TON ➡️ Standard TON Footstep NFT

@liketurbo
Copy link
Contributor Author

Left the request - nvim-treesitter/nvim-treesitter#2282 (comment)

@sepezho
Copy link

sepezho commented Jan 15, 2023

any updates here? How long it can take?

@amaanq
Copy link

amaanq commented Jan 22, 2023

I can take the necessary steps to add support to nvim-treesitter for FunC, but they follow a strict guide on how queries work, so I might have to do some edits/tweaks to the grammar/queries for that. Is that ok? If so I'll get started. And if anyone wants to co-maintain the grammar/queries let me know :)

@liketurbo
Copy link
Contributor Author

@amaanq I saw your merge request nvim-treesitter/nvim-treesitter#4259.

Great job 💪

I set the reward as "Standard TON Footstep NFT", thinking that it would be matter of only posting the comment, but as it seems there was additional work to be done.

@amaanq Could you provide a reward that would been appropriate for that task?
@Gusarich Can you confirm it

@amaanq
Copy link

amaanq commented Feb 3, 2023

idk how rewards work, nor do I know much about the ton Blockchain stuff. but if it's simple then sure send me a brief desc on what to do, otherwise you can claim this reward

@Gusarich
Copy link
Collaborator

Gusarich commented Feb 3, 2023

@amaanq just tell how much USD do you want for the completion of this footstep.

@amaanq
Copy link

amaanq commented Feb 3, 2023

@amaanq just tell how much USD do you want for the completion of this footstep.

I wasn't aware itd be a monetary compensation, whatever you think feels right is good for me 😅

@Gusarich
Copy link
Collaborator

Let's just get it back to 100 TON (250$) as it was suggested at first.
@amaanq can you please create a PR to add yourself to the "hall of fame"? also leave your ton wallet address there so that we can send you the reward.

@Gusarich
Copy link
Collaborator

Gusarich commented May 2, 2023

@amaanq can you please just send your TON wallet address here for the reward? Don't need to do anything else (we changed the rules a little bit)

@delovoyhomie
Copy link
Collaborator

@amaanq, have you finished this work? I am waiting for your response.

@liketurbo
Copy link
Contributor Author

liketurbo commented Aug 5, 2023

@amaanq, have you finished this work? I am waiting for your response.

FunC is now listed in the nvim-treesitter repo under the "Supported languages" section, which means you can enable syntax highlighting through Vim CLI or configuration.
Therefore, it's safe to say that this footstep is completed as per the "Definition of Done," and can be closed.

@delovoyhomie
Copy link
Collaborator

@amaanq, Are you here for a reward?
Please finish this footstep in accordance with Completion Stage.

@delovoyhomie delovoyhomie added Developer Tool Related to tools or utilities used by developers and removed footstep This is a TON Footstep issue labels Oct 7, 2023
@delovoyhomie
Copy link
Collaborator

Thank you for your participation, and we kindly ask you to provide your TON wallet address to receive the deserved reward. Once the reward is transferred to your account, we will officially conclude this initiative, confirming the fulfillment of all financial obligations.

@delovoyhomie delovoyhomie added the Progress Blocked Task halted due to obstacles or issues label Nov 30, 2023
@delovoyhomie
Copy link
Collaborator

Seems like we've lost connection with @amaanq. Please get in touch with us and we will reopen this issue.

@delovoyhomie delovoyhomie closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved This proposal is approved by the committee Developer Tool Related to tools or utilities used by developers Progress Blocked Task halted due to obstacles or issues
Projects
None yet
Development

No branches or pull requests

7 participants