Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise Button behavior #28

Closed
boerge1 opened this issue Nov 29, 2022 · 6 comments
Closed

Revise Button behavior #28

boerge1 opened this issue Nov 29, 2022 · 6 comments
Assignees

Comments

@boerge1
Copy link
Collaborator

boerge1 commented Nov 29, 2022

Proposal: change the button behavior the same as the fork of Thomas-Lehnert:

three Button
============
                                                      vol/next-prev inverted
           admin-menu  idle        pause       play         play
--------------------------------------------------------------------------
pause      select                  play        pause        pause
pauseLong  end adm     shutdown    shutdown    track#       track#
up         next                                next         vol++
upLong     next 10     shortcut2   shortcut2   vol++ cont.  next
down       prev                                prev         vol--
downLong   prev 10     shortcut3   shortcut3   vol-- cont.  prev
updownLong             shortcut1   shortcut1

five Button
===========
vol/next-prev inverted has no effect for 5 Buttons

           admin-menu  idle        pause       play
-----------------------------------------------------------
pause      select                  play        pause
pauseLong  end adm     shutdown    shutdown    track#
up         next                                next
upLong     next 10     shortcut2   shortcut2   next 10
down       prev                                prev
downLong   prev 10     shortcut2   shortcut3   prev 10
updownLong             shortcut1   shortcut1
four       next                                vol++
fourLong   next 10                             vol++ cont.
five       prev                                vol--
fiveLong   prev 10                             vol-- cont.

comments are welcome

edit: changed table above according to comments on http://discourse.voss.earth/t/tester-gesucht-tonuino-3-1/12086/90?u=boerge1
edit: changed table again (add continuously increase/decrease volume if long press)
edit: implement shutdown on pauseLong (the shortcut is now on updownLong

@boerge1
Copy link
Collaborator Author

boerge1 commented Nov 29, 2022

Made a first implementation on branch 'issue_028'.

@jochenberger
Copy link
Contributor

jochenberger commented Dec 1, 2022

I tried that but I wish we had
3-btn, not inverted:
Play upLong vol++ cont. and Play downLong vol-- cont. (see #24 and d75ada2#r90991535).

@boerge1
Copy link
Collaborator Author

boerge1 commented Dec 7, 2022

Created pull request #30

@boerge1 boerge1 self-assigned this Dec 7, 2022
@jochenberger
Copy link
Contributor

jochenberger commented Dec 7, 2022

vol/next-prev inverted has no effect for 5 Buttons

Should the respective section be removed from the admin menu then?

@jochenberger
Copy link
Contributor

jochenberger commented Dec 8, 2022

I tried that but I wish we had 3-btn, not inverted: Play upLong vol++ cont. and Play downLong vol-- cont. (see #24 and d75ada2#r90991535).

Oh, you already did that, I didn't notice until I just tried to change the behavior. 😆 Maybe you should say so in the comment.
Ah, no, I flashed the wrong branch.

@boerge1
Copy link
Collaborator Author

boerge1 commented Jan 16, 2023

Pull request #30 is merged

@boerge1 boerge1 closed this as completed Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants