Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No pause if card is removed too early #39

Closed
boerge1 opened this issue Jan 9, 2023 · 5 comments
Closed

No pause if card is removed too early #39

boerge1 opened this issue Jan 9, 2023 · 5 comments
Labels
bug Something isn't working pull_request_exists

Comments

@boerge1
Copy link
Collaborator

boerge1 commented Jan 9, 2023 •
edited
Loading

In mode "pause if card removed" we have a race condition if the card is removed before it starts to play. In this case it doesn't go to pause and start new if the card is inserted.
@boerge1
Copy link
Collaborator Author

boerge1 commented Jan 20, 2023

PR #48 created

@boerge1
Copy link
Collaborator Author

boerge1 commented Jan 20, 2023

PR #48 merged

@boerge1 boerge1 closed this as completed Jan 20, 2023
@boerge1
Copy link
Collaborator Author

boerge1 commented May 20, 2023

It goes to pause, but despite it the track is played

@boerge1 boerge1 reopened this May 20, 2023
@boerge1 boerge1 added the bug Something isn't working label May 20, 2023
@boerge1
Copy link
Collaborator Author

boerge1 commented May 20, 2023

Pull request #90 created

@boerge1
Copy link
Collaborator Author

boerge1 commented Jun 24, 2023

Pulli request #90 merged

@boerge1 boerge1 closed this as completed Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working pull_request_exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@boerge1