Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statemachine remains in StartPlay forever is mp3 files missing #44

Closed
boerge1 opened this issue Jan 15, 2023 · 2 comments
Closed

Statemachine remains in StartPlay forever is mp3 files missing #44

boerge1 opened this issue Jan 15, 2023 · 2 comments
Assignees
@boerge1

Comments

@boerge1
Copy link
Collaborator

boerge1 commented Jan 15, 2023

If the 262.mp3 file is missing the state StartPlay tries to start it and and waits until it is finished. But because of
OnPlayFinished() is never called by the DFMiniMp3 library (really this play was never started), there is no end detection.
Fix:
Enable CHECK_MISSING_ONPLAYFINISHED and fix this implementation
@boerge1 boerge1 self-assigned this Jan 15, 2023
@boerge1
Copy link
Collaborator Author

boerge1 commented Jan 15, 2023

opened PR #46

@boerge1
Copy link
Collaborator Author

boerge1 commented Jan 16, 2023

Pr #46 merged, so close this issue

@boerge1 boerge1 closed this as completed Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boerge1 boerge1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@boerge1