From 92c664a0dbd10bb850182df63be8d87ebba65618 Mon Sep 17 00:00:00 2001 From: Aaron Powell Date: Fri, 11 Oct 2024 13:51:45 +1100 Subject: [PATCH] Fixing how the assemblies are referenced in NuGet Setting the DevelopmentDependency property will cause the nuspec to have a developmentDependency node in the metadata, which influences how the package is referenced in the consuming projects (see https://github.com/NuGet/NuGet.Client/blob/a41fd92fbbd65fb430e96b11c3277e2c96184474/src/NuGet.Core/NuGet.Build.Tasks.Pack/NuGet.Build.Tasks.Pack.targets#L236 for the task entrypoint). This property would make sense if we were shipping something only for development in the nupkg (like just a source generator or analyzer) but since we're not, we're also shipping a runtime, we don't want the package considered a developmentDependency as that will influence the IncludeAssets and PrivateAssets properties of the package reference. https://learn.microsoft.com/nuget/reference/nuspec#developmentdependency is the nuspec reference with more details here: https://github.com/NuGet/Home/wiki/DevelopmentDependency-support-for-PackageReference --- src/CSnakes.Runtime/Packaging.targets | 1 - src/Packaging.props | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/CSnakes.Runtime/Packaging.targets b/src/CSnakes.Runtime/Packaging.targets index d831688c..43d59fa5 100644 --- a/src/CSnakes.Runtime/Packaging.targets +++ b/src/CSnakes.Runtime/Packaging.targets @@ -7,7 +7,6 @@ $(NoWarn);NU5128 - true $(EnableLocalPackaging) diff --git a/src/Packaging.props b/src/Packaging.props index 4944d5c4..40e316af 100644 --- a/src/Packaging.props +++ b/src/Packaging.props @@ -5,7 +5,7 @@ logo.jpeg README.md https://github.com/tonybaloney/CSnakes - 1.0.18 + 1.0.19 LICENSE true