-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On touch devices scroll closes popup #18
Comments
Absolutely not true. Just checked. Try on the demo page. |
There is not an example that use hideOnClickOutside on demo page. Can you check this example https://angular-ivy-awfugd.stackblitz.io? Open the poppover and scroll with touch. Poppover should not close when user just scroll, it should close on click outside. Editor Link |
@berkayyildiz it seems that to fix what you say we should revert this commit. I'll do some tests. I'm locking comments anyway. I will tag you when I have news. |
Fixed in v 13.0.1 |
Describe the bug
On touch devices scroll closes popup
To Reproduce
Add click trigger and closeOnClickOutside attribute to popup. Open on a mobile device and scroll with touch.
Expected behavior
Popup should remain.
Additional context
I checked old repo and to get click events on some mobile devices
this._globalEventListeners.push(this._renderer.listen("document", "touchend", this.hideOnClickOutsideHandler.bind(this)));
code added topopper.directive.ts
. But this cause a scroll as click outside.Similar bug issue on old repo
The issue that caused the error on old repo
The text was updated successfully, but these errors were encountered: