Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On touch devices scroll closes popup #18

Closed
berkayyildiz opened this issue Jan 15, 2022 · 4 comments
Closed

On touch devices scroll closes popup #18

berkayyildiz opened this issue Jan 15, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@berkayyildiz
Copy link

Describe the bug
On touch devices scroll closes popup

To Reproduce
Add click trigger and closeOnClickOutside attribute to popup. Open on a mobile device and scroll with touch.

Expected behavior
Popup should remain.

Additional context
I checked old repo and to get click events on some mobile devices this._globalEventListeners.push(this._renderer.listen("document", "touchend", this.hideOnClickOutsideHandler.bind(this)));code added to popper.directive.ts. But this cause a scroll as click outside.

Similar bug issue on old repo
The issue that caused the error on old repo

@tonysamperi
Copy link
Owner

tonysamperi commented Jan 15, 2022

Absolutely not true. Just checked. Try on the demo page.

@tonysamperi tonysamperi added the invalid This doesn't seem right label Jan 15, 2022
@berkayyildiz
Copy link
Author

berkayyildiz commented Jan 15, 2022

There is not an example that use hideOnClickOutside on demo page.

Can you check this example https://angular-ivy-awfugd.stackblitz.io? Open the poppover and scroll with touch. Poppover should not close when user just scroll, it should close on click outside.

Editor Link
https://stackblitz.com/edit/angular-ivy-awfugd

@tonysamperi
Copy link
Owner

tonysamperi commented Jan 15, 2022

@berkayyildiz it seems that to fix what you say we should revert this commit.

MrFrankel/ngx-popper@96edf1a

I'll do some tests. I'm locking comments anyway. I will tag you when I have news.
Cheers and thanks for reporting.

@tonysamperi tonysamperi reopened this Jan 15, 2022
Repository owner locked as too heated and limited conversation to collaborators Jan 15, 2022
@tonysamperi tonysamperi added Investigating and removed invalid This doesn't seem right labels Jan 15, 2022
@tonysamperi
Copy link
Owner

Fixed in v 13.0.1

@tonysamperi tonysamperi added bug Something isn't working and removed Investigating labels Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants