Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue tools: Expand searching to apply to multiple fields #218

Closed
eritbh opened this issue Feb 10, 2020 · 11 comments · Fixed by #263
Closed

Queue tools: Expand searching to apply to multiple fields #218

eritbh opened this issue Feb 10, 2020 · 11 comments · Fixed by #263
Labels
enhancement New feature or request good first issue a good issue for people new to toolbox development module: queuetools
Milestone

Comments

@eritbh
Copy link
Member

eritbh commented Feb 10, 2020

This has to be a simple fix, it's kinda a wonder nobody's complained about it before.

@eritbh eritbh added enhancement New feature or request module: queuetools labels Feb 10, 2020
@eritbh eritbh added this to the v5.2.x milestone Feb 10, 2020
@eritbh eritbh added the good first issue a good issue for people new to toolbox development label Feb 10, 2020
@creesch
Copy link
Member

creesch commented Feb 11, 2020

Probably because barely anyone uses that functionality :P I had to double check as at first I wasn't sure what the issue was about.

@creesch
Copy link
Member

creesch commented Feb 11, 2020

Oooh... now that I think about it "select by post ID" would be cool as well.

@creesch
Copy link
Member

creesch commented Feb 11, 2020

Sorry for the comment spam, I think this should apply to all items there. So also domain, user and title.

A neat QoL improvement would be to provide a selection list of all possible items on page like we currently do with user search input.

@eritbh
Copy link
Member Author

eritbh commented Feb 12, 2020

Yeah, that sounds like a good idea. Just throw it all in a generic "select by search" option and then write up a little static window that has a text field and checkboxes for subreddit, title, body, URL, author, etc.

@eritbh eritbh changed the title Queue tools: make subreddit selection not case-sensitive Queue tools: Expand searching to apply to multiple fields Feb 12, 2020
@creesch
Copy link
Member

creesch commented Feb 12, 2020

Something like that yeah, giving it a proper interface. Not sure if we want just one input field or leave it like it is now but on clicking make each item an input field instead of the popup input we have now.

@creesch
Copy link
Member

creesch commented Feb 12, 2020

A bit like this (domain)
image

And then when typing have the suggestion thing pop up like so

image

@Venefilyn
Copy link
Member

Venefilyn commented Feb 29, 2020

For this feature to be good, all of these in red need to be changed to have consistency

image

Ideally we shouldn't have a bunch of inputs in dropdowns. Instead we could make due with an expand/filter button for another row of filtering options

@creesch
Copy link
Member

creesch commented Mar 5, 2020

Additional suggestion report reason selection.

@creesch
Copy link
Member

creesch commented Mar 5, 2020

Ideally we shouldn't have a bunch of inputs in dropdowns

Well I have been thinking that instead of a dropdown we make use of a popup when the select button is clicked. Giving us enough space and UI utility to give people proper options.

Basically like a search engine advanced search options for narrowing down a search result.

image

@Venefilyn
Copy link
Member

Venefilyn commented Mar 5, 2020

Having a click to expand panel sort of thing would be possible as well, means we can have real-time results without having to do a pop-up every time. Makes it easier to do quick searches without going through a popup every time

To see what I mean, look at https://www.patternfly.org/v4/documentation/react/components/datatoolbar#component-managed-toggle-groups in a medium viewport, filter button will be there which expands a panel when clicked

@creesch
Copy link
Member

creesch commented Mar 5, 2020

But that requires us to build an UI element we currently don't have. Which is possible but then I'd like to understand the advantage a bit more. I am also not entirely sure how that would allow for the variety of options we have now.

What I currently have in mind would be more along the lines of this

image

But then not ugly and functional ;) It also does allow us to explain some options better in line as some of these things only make sense for people that have modded long enough to know all the reddit mod terminology.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue a good issue for people new to toolbox development module: queuetools
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants