Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments on new page setting breaks old reddit "open in new window" setting #366

Closed
creesch opened this issue Sep 7, 2020 · 2 comments
Closed
Assignees
Labels
bug something isn't working
Milestone

Comments

@creesch
Copy link
Member

creesch commented Sep 7, 2020

This one

self.register_setting('commentsAsFullPage', {
type: 'boolean',
default: false,
advanced: false,
title: 'Always open comments as new page (instead of lightbox).',
});

Not entirely sure how it is breaking all links (maybe the used regex is faulty) but it needs to be looked at. It is also intended to only work on new reddit but there is no explicit check to make it only work there.

@creesch creesch added the bug something isn't working label Sep 7, 2020
@creesch
Copy link
Member Author

creesch commented Sep 7, 2020

Some more testing shows it is working okay, just wonky on old reddit due to how newer content types are linked. So I am just going to go ahead and make sure it only runs on new reddit.

@creesch
Copy link
Member Author

creesch commented Oct 11, 2020

fixed with b6da7fa

@creesch creesch closed this as completed Oct 11, 2020
@eritbh eritbh added this to the v5.5 milestone Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants