Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flair selection has visual bugs with flair template selection #457

Closed
Venefilyn opened this issue Feb 23, 2021 · 3 comments · Fixed by #458
Closed

Flair selection has visual bugs with flair template selection #457

Venefilyn opened this issue Feb 23, 2021 · 3 comments · Fixed by #458
Labels
bug something isn't working module: modbutton
Milestone

Comments

@Venefilyn
Copy link
Member

Introduced in #418. There are both bugs and edge-cases not taken care of:

  • Clearing a flair doesn't work?
  • No way to get value from flair templates to text and class
  • It is not clear if selecting a flair template will overwrite text and class
@xeoth
Copy link
Contributor

xeoth commented Feb 23, 2021

Clearing a flair doesn't work?

Cannot reproduce that

No way to get value from flair templates to text and class

Do you mean that changing the flair template should override the fields right after selection? Right now, class and text are filled silently after clicking Save if not typed in by the user.

@ickybus
Copy link

ickybus commented Feb 23, 2021

Do you mean that changing the flair template should override the fields right after selection? Right now, class and text are filled silently after clicking Save if not typed in by the user.

this is not the behavior experienced when selecting template "None" - i had to both select "None" and manually clear the field to get it to save.

@xeoth
Copy link
Contributor

xeoth commented Feb 23, 2021

Ah, in that way. Can reproduce now. It seems like Reddit's API autofills the template ID when the user has one already, but is not specified in the request. Will dig into how to avoid that.

@eritbh eritbh added bug something isn't working module: modbutton labels Feb 23, 2021
@eritbh eritbh modified the milestones: v5.6, v5.5.4 Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working module: modbutton
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants