Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mod macros: comment isn't stickied if "distinguish" isn't selected as well #533

Closed
creesch opened this issue Sep 20, 2021 · 1 comment · Fixed by #543
Closed

Mod macros: comment isn't stickied if "distinguish" isn't selected as well #533

creesch opened this issue Sep 20, 2021 · 1 comment · Fixed by #543
Assignees
@eritbh
Labels
bug something isn't working module: macros
Milestone
v5.6.4

Comments

@creesch
Copy link
Member

creesch commented Sep 20, 2021

Reported through modmail, haven't been able to confirm or test it but made this issue so we don't loose track of it.
@creesch creesch added bug something isn't working module: macros needs repro has not been reproduced by a contributor or needs steps for reproduction labels Sep 20, 2021
@eritbh
Copy link
Member

eritbh commented Nov 19, 2021

Reproduced, issue is here https://github.com/toolbox-team/reddit-moderator-toolbox/blob/master/extension/data/modules/macros.js#L477-L479

@eritbh eritbh self-assigned this Nov 19, 2021
@eritbh eritbh removed the needs repro has not been reproduced by a contributor or needs steps for reproduction label Nov 19, 2021
@eritbh eritbh mentioned this issue Nov 19, 2021
Merged
@eritbh eritbh added this to the v5.6.4 milestone Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eritbh eritbh

Labels
bug something isn't working module: macros
Projects
None yet
Milestone
v5.6.4
Development

Successfully merging a pull request may close this issue.

Distinguish macro comments whenever stickying them toolbox-team/reddit-moderator-toolbox
2 participants
@creesch @eritbh