Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbox buttons break modmail sidebar #579

Closed
eritbh opened this issue Aug 17, 2022 · 1 comment · Fixed by #595
Closed

Toolbox buttons break modmail sidebar #579

eritbh opened this issue Aug 17, 2022 · 1 comment · Fixed by #595
Labels
bug something isn't working
Milestone

Comments

@eritbh
Copy link
Member

eritbh commented Aug 17, 2022

A recent change to the user info sidebar in modmail means that the position where Toolbox inserts the user info buttons now results in broken display.

image

The user info no longer scrolls, only the tabs beneath do, so we have limited vertical space to work with. We probably want to reduce our buttons back down to the single-letter labels and insert them underneath the username (.ModIdCard__UserNameMetaData) or profile link (.ModIdCard__UserProfileLink). We can also steal one of those classes to get text centering for free, to match up with the rest of the display.

@eritbh eritbh added the bug something isn't working label Aug 17, 2022
@eritbh eritbh added this to the v6.0 milestone Aug 17, 2022
@eritbh
Copy link
Member Author

eritbh commented Aug 18, 2022

Reddit has reverted this sidebar change for now, so it's not something we need to address immediately for v6.

@eritbh eritbh removed this from the v6.0 milestone Aug 18, 2022
@eritbh eritbh added this to the v6.0.2 milestone Aug 24, 2022
@eritbh eritbh moved this to Todo in Toolbox backlog Aug 2, 2023
@eritbh eritbh moved this from Todo to Done in Toolbox backlog Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant