-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use same window for autoplotting #240
Comments
Sound useful to me :) i think it's worth creating a PR with the implementation
sounds correct to me. i think it will be more obvious with a PR opened, also other maintainers/reviewers can chip in |
This is an excellent suggestion! As a note on that: there i've recently implemented running each autoplot window in a dedicated process (which makes things a lot faster/more responsive for us). Me and one of my students are starting to do some work on monitr, and we could include work on this feature with that. I will likely have some time after the semester ends (in about a week) to put some work into this. |
Glad to hear this feature could be an addition to Plottr! If there is a part of this that I can help out with please let me know. @wpfff I hadn't yet noticed that inspectr and monitr were two different classes. Is monitr continuously checking for new/updated datasets, and it then refreshes plottr and optionally auto-plots the new data sets? |
i'll think about what a good implementation would look like, and get back to you here. monitr is kind of a sibling of inspectr, but with a different data backend. my lab, for instance, prefers hdf5 based data storage over sqlite. so we're not using the qcodes dataset, but a simple wrapper around hdf5 that stores each measurement in a separate file (similar to older versions of qcodes or qtlab. it comes with plottr, in |
I've found the "Auto-plot new" feature of Plottr quite useful because it allows me to always view the currently active measurement.
However, it is currently programmed such that every new measurement opens a new window, and also doesn't close the previous window. This can create an excessive amount of windows, especially when executing several measurements in quick succession.
I propose the option to have a dedicated window for auto-plotting. Whenever a new measurement is started, it will clear contents of that window, and replace it with the contents of the new dataset. It could for example be enabled by a second checkbox as such:
Edit: It looks like uploading an image doesn't work. The example showed a second checkbox with text "Same window" below the "Auto-plot new" checkbox
I wanted to see how others feel about this, and if others agree it would be a good addition, what a good strategy is to implement this.
Looking over the code, I think the best strategy would be to have an attribute
QCodesDBInspector._autoplot_window
which could point towards a dedicated autoplot window. Further,AutoPlotMainWindow
should have a method to clear it's contents and to load new contents.The text was updated successfully, but these errors were encountered: