Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for refresh(options) where options will extend current options #241

Open
pbowyer opened this issue Aug 23, 2016 · 4 comments
Open
Assignees

Comments

@pbowyer
Copy link

pbowyer commented Aug 23, 2016

I was really excited to see config parameters can now be passed to refresh(), hoping this would let me change the colour of the text when the dial was completely full (it's hard to tell on a small gauge if you've got there or are a couple of items off being 'full').

However, all my attempts to change settings have failed. For example:

gauge.refresh(100, null, {titleFontColor: '#ffcc00'});
gauge.refresh(105, false, {labelFontColor: '#ffcc00'});
gauge.refresh(115, null, {valueFontColor: '#00ccff'});

This is using the current GitHub version of justgage.js (commit: ce021d6). Stepping in with a debugger the config settings are updated on line 870, but there appears no code to render these changes after it?

@toorshia
Copy link
Owner

You are correct, there is no code to render changes. This remains to be done.

@javaday
Copy link

javaday commented Aug 23, 2016

Yea, I just ran into this myself. I am trying to update the min configuration during a refresh. Any ETA on fixing the rendering?

@toorshia
Copy link
Owner

I'd like to roll this out in a month or so.

@robertsLando robertsLando changed the title Clarify which config parameters can be passed to refresh() Support for refresh(options) where options will extend current options Aug 6, 2019
@deezone
Copy link
Contributor

deezone commented Sep 19, 2019

In development...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants