Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a preferences API so apps can share basic behaviours #10109

Merged
merged 1 commit into from
Mar 15, 2019

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Feb 24, 2019

Resolve #9821

GET /api/v1/preferences example output:

{
  "posting:default:visibility": "public",
  "posting:default:sensitive": false,
  "posting:default:language": null,
  "reading:expand:media": "default",
  "reading:expand:spoilers": false
}

@Gargron Gargron added api REST API, Streaming API, Web Push API work in progress Not to be merged, currently being worked on labels Feb 24, 2019
@ykzts
Copy link
Member

ykzts commented Mar 5, 2019

oops. this PR was draft

@Gargron
Copy link
Member Author

Gargron commented Mar 5, 2019

@Tak @connyduck Is this sufficient?

@Gargron Gargron marked this pull request as ready for review March 5, 2019 17:51
@Tak
Copy link
Contributor

Tak commented Mar 6, 2019

@Gargron Sorry, it's not clear to me from the diff - does this also allow apps to write these preferences?

A minor comment on the output format - if the keys are meant to be hierarchical, why not represent them that way in the json?

"posting": {
  "default": {
    "visibility": "public",
    "sensitive": false,
    "language": null
  }
},
"reading": { //...```

@Gargron Gargron merged commit d94e21f into master Mar 15, 2019
@Gargron Gargron deleted the feature-preferences-api branch March 15, 2019 01:41
@Tak
Copy link
Contributor

Tak commented Mar 15, 2019

Cool, good discussion.

hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
messenjahofchrist pushed a commit to Origin-Creative/mastodon that referenced this pull request Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api REST API, Streaming API, Web Push API work in progress Not to be merged, currently being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants