When serializing polls over OStatus, serialize poll options to text #10160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
reviewed
Mar 4, 2019
app/lib/formatter.rb
Outdated
| @@ -19,6 +19,10 @@ def format(status, **options) | |||
|
|
|||
| raw_content = status.text | |||
|
|
|||
| if status.poll && options[:inline_poll_options] | |||
There was a problem hiding this comment.
You mean, checking the option then the poll? Or have it on by default? Changed it for the former.
ClearlyClaire
force-pushed
the
fixes/ostatus-include-poll-options
branch
from
54679ce
to
4231b44
Compare
ClearlyClaire
force-pushed
the
fixes/ostatus-include-poll-options
branch
from
4231b44
to
56177f1
Compare
Gargron
approved these changes
Mar 5, 2019
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
…astodon#10160) * When serializing polls over OStatus, serialize poll options to text * Do the same for RSS feeds * Use “[ ] ” as a prefix for poll options instead of “- ”
messenjahofchrist
pushed a commit
to Origin-Creative/mastodon
that referenced
this pull request
Jul 30, 2021
…astodon#10160) * When serializing polls over OStatus, serialize poll options to text * Do the same for RSS feeds * Use “[ ] ” as a prefix for poll options instead of “- ”
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.