Avoid race condition when streaming deleted statuses #10280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
force-pushed
the
fixes/streaming-delete-race-condition
branch
3 times, most recently
from
03baf47
to
a026b85
Compare
ClearlyClaire
force-pushed
the
fixes/streaming-delete-race-condition
branch
from
a026b85
to
0f0758c
Compare
|
Ok, this was a bit trickier than expected, as |
ClearlyClaire
force-pushed
the
fixes/streaming-delete-race-condition
branch
from
fadf369
to
e1ca3c5
Compare
ClearlyClaire
force-pushed
the
fixes/streaming-delete-race-condition
branch
from
e1ca3c5
to
4f73117
Compare
ykzts
approved these changes
Mar 15, 2019
Gargron
approved these changes
Mar 16, 2019
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
* Avoid race condition when streaming deleted statuses * Move redis lock to DistributionWorker to avoid extra Redis value
messenjahofchrist
pushed a commit
to Origin-Creative/mastodon
that referenced
this pull request
Jul 30, 2021
* Avoid race condition when streaming deleted statuses * Move redis lock to DistributionWorker to avoid extra Redis value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relies on new redis locks and values so I'm not sure how efficient that is.
But I can't see other ways to prevent those race conditions (basically,
DistributeWorkerdoing its job while a status has been/is being deleted, resulting in the status being pushed to timelines after it was deleted).