Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show timeline preview or directory widgets if they are disabled #10284

Merged
merged 1 commit into from
Mar 19, 2019

Conversation

ClearlyClaire
Copy link
Contributor

No description provided.

@Gargron
Copy link
Member

Gargron commented Mar 15, 2019

I'm not convinced why

@ClearlyClaire
Copy link
Contributor Author

(Removing the closed messages commit from this, it's still WiP and another subject entirely)

Well, I find it only confusing. Also, the directory still shows users who opted in even if the feature has been disabled.

@Gargron
Copy link
Member

Gargron commented Mar 15, 2019

Also, the directory still shows users who opted in even if the feature has been disabled.

Technically, it doesn't show the users, it shows the avatars--and I think even if the directory cannot be browsed, it's not a bad detail to convince the reader that there are people on the server (not a "ghost town").

I understand that being greyed out as an indicator for being disabled is perhaps not a fully intuitive thing, but maybe there are ways to adjust the "disabled" design to make it more obvious. (The "disabled" cursor on mouse-over, for example?)

@ClearlyClaire
Copy link
Contributor Author

I'm still not sure what is the benefit of showing a feature that's not enabled.
I guess I could understand if it was some kind of checklist of features the instance offers to a logged in user, but that's not the case.

@Gargron Gargron merged commit d041b7a into mastodon:master Mar 19, 2019
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
messenjahofchrist pushed a commit to Origin-Creative/mastodon that referenced this pull request Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants