Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export and import hide_notifications alongside user mutes #10335

Merged
merged 3 commits into from
Apr 3, 2019
Merged

Export and import hide_notifications alongside user mutes #10335

merged 3 commits into from
Apr 3, 2019

Conversation

ClearlyClaire
Copy link
Contributor

No description provided.

@ClearlyClaire ClearlyClaire force-pushed the fixes/export-hide_notifications branch 3 times, most recently from b2b59ad to 3cabbb1 Compare March 21, 2019 15:11
@ClearlyClaire ClearlyClaire force-pushed the fixes/export-hide_notifications branch 5 times, most recently from 4402645 to 8a59546 Compare March 21, 2019 16:42
@ClearlyClaire ClearlyClaire force-pushed the fixes/export-hide_notifications branch from 8a59546 to a0df95c Compare March 21, 2019 17:00
@ClearlyClaire ClearlyClaire marked this pull request as ready for review March 21, 2019 17:09
@Gargron
Copy link
Member

Gargron commented Mar 28, 2019

I am concerned that this is a pandora's box because we also have follows with/without reblogs and whatnot. So far the CSV files were just lists of strings, very simple and understandable, now we are putting unexplained booleans in them. Maybe this should require the introduction of a header row.

@ClearlyClaire
Copy link
Contributor Author

Ah, yes, we could add a header, that would also help with potential future changes.
We need to be careful to chose header names that might not be interpreted as usernames by older versions though

@ClearlyClaire ClearlyClaire force-pushed the fixes/export-hide_notifications branch 6 times, most recently from 94449e7 to d73586d Compare March 29, 2019 16:45
@ClearlyClaire
Copy link
Contributor Author

Well, I'm afraid I have no idea why the test fails on 2.4 and 2.5 but not 2.6.

@ClearlyClaire ClearlyClaire force-pushed the fixes/export-hide_notifications branch from d73586d to d3e42bb Compare March 29, 2019 16:58
@ClearlyClaire
Copy link
Contributor Author

It appears it's a bug in the CSV module in older versions of Ruby when involving both headers and empty lines 😩
I modified the test suite to not have such empty lines…

@ClearlyClaire ClearlyClaire force-pushed the fixes/export-hide_notifications branch 3 times, most recently from 905686c to 0c4ac4f Compare March 31, 2019 12:16
@ClearlyClaire ClearlyClaire force-pushed the fixes/export-hide_notifications branch from 0c4ac4f to 44c6fa3 Compare March 31, 2019 12:26
@ClearlyClaire
Copy link
Contributor Author

Updated to use more natural-looking headers such as “Account address” instead of “#account”

@Gargron Gargron merged commit d4882aa into mastodon:master Apr 3, 2019
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
@ClearlyClaire @hiyuki2578
Export and import hide_notifications alongside user mutes (mastodon…
d6b4cb8 
…#10335)

* Export hide_notifications along with user mutes

* Import hide_notifications along with muted users list

* Add headers for CSV exports
messenjahofchrist pushed a commit to Origin-Creative/mastodon that referenced this pull request Jul 30, 2021
@ClearlyClaire @Gargron
Export and import hide_notifications alongside user mutes (mastodon…
e315428 
…#10335)

* Export hide_notifications along with user mutes

* Import hide_notifications along with muted users list

* Add headers for CSV exports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gargron Gargron Gargron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ClearlyClaire @Gargron