Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ActivityPub representation for identity proofs #10414

Merged
merged 2 commits into from
Mar 30, 2019

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Mar 29, 2019

I define one new property: toot:IdentityProof, which is an object type. The proofs go into the account's attachment property. The name represents the identity's (user)name, the signatureAlgorithm (from the security context) identifies the identity proof platform (e.g. keybase), and signatureValue (also from the security context) carries the cryprographic token used for verification. You could say that the signature algorithm "keybase" tells you how to verify the signature token.

@Gargron Gargron added the activitypub Protocol-related changes, federation label Mar 29, 2019
@Gargron Gargron force-pushed the feature-identity-proofs-federation branch from 8a31050 to e2703ba Compare March 29, 2019 02:48
@Gargron Gargron marked this pull request as ready for review March 29, 2019 02:57
@ClearlyClaire
Copy link
Contributor

Seems a bit weird to me to reuse signatureAlgorithm and signatureValue for that but otherwise this seems like a sensible approach.

@nightpool
Copy link
Member

are the other signature algorithms we use URI values? should this one be as well?

@Gargron
Copy link
Member Author

Gargron commented Mar 29, 2019

They are not URIs, no. Stuff like Rsa2017 or whatever.

@Gargron Gargron requested a review from ykzts March 30, 2019 01:00
@Gargron Gargron merged commit 1714ea5 into master Mar 30, 2019
@Gargron Gargron deleted the feature-identity-proofs-federation branch March 30, 2019 01:12
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
* Add ActivityPub representation for identity proofs

* Add tests
messenjahofchrist pushed a commit to Origin-Creative/mastodon that referenced this pull request Jul 30, 2021
* Add ActivityPub representation for identity proofs

* Add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
activitypub Protocol-related changes, federation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants