Fix tootctl accounts cull
#10460
Merged
Fix tootctl accounts cull
#10460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the dry run mode is basically useless.
|
(sorry Code Climate robot, I'm too used to bash scripting) |
BenLubar
changed the title
tootctl accounts cull
ClearlyClaire
approved these changes
Apr 3, 2019
| skip_domains = Set.new | ||
| dry_run = options[:dry_run] ? ' (DRY RUN)' : '' | ||
|
|
||
| Account.remote.where(protocol: :activitypub).partitioned.find_each do |account| | ||
| next if account.updated_at >= skip_threshold || (account.last_webfingered_at.present? && account.last_webfingered_at >= skip_threshold) | ||
|
|
||
| code = 0 |
There was a problem hiding this comment.
I would have put a next like in the other rescue instead of that, but LGTM
|
Please modify the changelog with the corresponding message as well |
Gargron
reviewed
Apr 4, 2019
Gargron
reviewed
Apr 4, 2019
Gargron
approved these changes
Apr 4, 2019
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
* List the actual accounts that would have been culled during a dry run. Otherwise, the dry run mode is basically useless. * Prevent unreachable domains from inheriting the previous status code. * Update CHANGELOG.md for mastodon#10460.
messenjahofchrist
pushed a commit
to Origin-Creative/mastodon
that referenced
this pull request
Jul 30, 2021
* List the actual accounts that would have been culled during a dry run. Otherwise, the dry run mode is basically useless. * Prevent unreachable domains from inheriting the previous status code. * Update CHANGELOG.md for mastodon#10460.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent unreachable domains from inheriting the previous status code.
Also list the actual accounts that would have been culled during a dry run.
(Otherwise, the dry run mode is basically useless.)