-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add toot source to delete result to ease Delete & Redraft #10669
Add toot source to delete result to ease Delete & Redraft #10669
Conversation
I am a little concerned/unsure about the naming and the semantics of adding stuff to entities--I am not a fan of the Another option, instead of creating a |
I'm weary of directly returning the content because it may be an issue for us down the road if we want to add stuff later on. I think having the complete status could be useful for clients as well, depending on how they handle various things… but it probably isn't necessary. If you prefer |
…ource is requested
Oh, I think I misunderstood what you meant. Returning the full status but with the |
…0669) * Return Status with raw text in raw_content when deleting a status * Use raw content if available on delete & redraft * Rename raw_content to text; do not serialize formatted content when source is requested
…0669) * Return Status with raw text in raw_content when deleting a status * Use raw content if available on delete & redraft * Rename raw_content to text; do not serialize formatted content when source is requested
…0669) * Return Status with raw text in raw_content when deleting a status * Use raw content if available on delete & redraft * Rename raw_content to text; do not serialize formatted content when source is requested
Currently, a client has to parse the formatted status when doing Delete & Redraft.
This is not trivial, and even the WebUI does not do it correctly for mention to users with weird URIs.
This PR returns the status in the
delete
reply with an additionalraw_content
field containing exactly the text that was initially input.