Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve rate limiting #10860

Merged
merged 3 commits into from
May 27, 2019
Merged

Improve rate limiting #10860

merged 3 commits into from
May 27, 2019

Conversation

ClearlyClaire
Copy link
Contributor

  • Use actual client IP for whitelisting and rate limiting when a reverse-proxy is involved
  • Reduce allowed number of unauthenticated API requests
  • Aggressively limit requests which involve paging

@ClearlyClaire
Copy link
Contributor Author

I'm not sure how much sense the limits make, and they'll probably affect search engine crawlers negatively.
One reason for this was to make life harder for people trying to archive public toots of an instance by crawling. I don't know how effective those limits would be.

@Gargron Gargron merged commit 0e9b8be into mastodon:master May 27, 2019
noellabo added a commit to noellabo/mastodon that referenced this pull request May 28, 2019
@noellabo
Revert "Improve rate limiting (mastodon#10860)"
335e8d7 
This reverts commit 0e9b8be.
@mayaeh mayaeh mentioned this pull request May 28, 2019
Merged
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
@ClearlyClaire @hiyuki2578
Improve rate limiting (mastodon#10860)
fe06c61 
* Rate limit based on remote address IP, not on potential reverse proxy

* Limit rate of unauthenticated API requests further

* Rate-limit paging requests to one every 3 seconds
rtucker pushed a commit to vulpineclub/mastodon that referenced this pull request Jan 7, 2021
@ClearlyClaire
Improve rate limiting (mastodon#10860)
c068f90 
* Rate limit based on remote address IP, not on potential reverse proxy

* Limit rate of unauthenticated API requests further

* Rate-limit paging requests to one every 3 seconds
messenjahofchrist pushed a commit to Origin-Creative/mastodon that referenced this pull request Jul 30, 2021
@ClearlyClaire @Gargron
Improve rate limiting (mastodon#10860)
17b6fc7 
* Rate limit based on remote address IP, not on potential reverse proxy

* Limit rate of unauthenticated API requests further

* Rate-limit paging requests to one every 3 seconds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gargron Gargron Gargron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ClearlyClaire @Gargron